Commit 917160f1 authored by Gladys Forte's avatar Gladys Forte

Restrict a requestor to submit a CR without atleast 1 approver v3

parent 337c9802
...@@ -1195,6 +1195,17 @@ class ChangeRequestFormPost(APIView): ...@@ -1195,6 +1195,17 @@ class ChangeRequestFormPost(APIView):
return Response(message, return Response(message,
status=status.HTTP_400_BAD_REQUEST) status=status.HTTP_400_BAD_REQUEST)
# Restrict a requestor to submit a CR without atleast 1 approver
counter = change_request.validation_existing_approver(frm_approvers)
if form_header['status'].lower() == 'pending' and counter == 0:
message = {
'code': 400,
'status': 'failed',
'message': 'Please select at least 1 approver before submitting this request.',
}
return Response(message, status=status.HTTP_400_BAD_REQUEST)
data_list_approver = [] data_list_approver = []
data_list_stake = [] data_list_stake = []
data_list_attach = [] data_list_attach = []
...@@ -1241,7 +1252,6 @@ class ChangeRequestFormPost(APIView): ...@@ -1241,7 +1252,6 @@ class ChangeRequestFormPost(APIView):
# create form approvers # create form approvers
frm_approvers = form_header['frm_approvers'] frm_approvers = form_header['frm_approvers']
counter = 0
for frm_approver in frm_approvers: for frm_approver in frm_approvers:
frm_approver['form_code'] = frm_id frm_approver['form_code'] = frm_id
data_list_approver.append(frm_approver) data_list_approver.append(frm_approver)
......
...@@ -767,6 +767,16 @@ def cr_routing_actions(approver_instance, current_user, move_to_level): ...@@ -767,6 +767,16 @@ def cr_routing_actions(approver_instance, current_user, move_to_level):
return True return True
def validation_existing_approver(approvers):
counter = 0
for approver in approvers:
# count all delegation not equal to Requestor and Vendor
if approver['delegation'] not in ['DELEGATION-20191119-0000002', 'DELEGATION-20191119-0000001']:
counter = counter + 1
return counter
return counter
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment