template approver serializer

app/applicationlayer/cms/template/approver/serializers.py

@@ -9,53 +9,38 @@ class ChangeRequestTemplateApproversSerializer(
     def to_representation(self, instance):
         try:
             ret = super().to_representation(instance)
-            user_object = {
-                "id": instance.user.id,
-                "name": instance.user.name,
-                "username": instance.user.username,
-                "code": instance.user.code,
-                "email": instance.user.email,
-                "contact_no": instance.user.contact_no
-            }
-            ret['company'] = {
-                "id": instance.user.department.company.id,
-                "code": instance.user.department.company.code,
-                "name": instance.user.department.company.name
-            }
-            ret['department'] = {
-                "id": instance.user.department.id,
-                "code": instance.user.department.code,
-                "name": instance.user.department.name
-            }
-            ret['user'] = user_object
 
-            if instance.user or instance.delegation.lower() == 'requestor':
-                ret['editable_user'] = False
-            else:
-                ret['editable_user'] = True
+            if instance.user:
+                user_object = {
+                    "id": instance.user.id,
+                    "name": instance.user.name,
+                    "username": instance.user.username,
+                    "code": instance.user.code,
+                    "email": instance.user.email,
+                    "contact_no": instance.user.contact_no
+                }
 
-            if instance.company or instance.delegation.lower() == 'requestor':
+                ret['company'] = {
+                    "id": instance.user.department.company.id,
+                    "code": instance.user.department.company.code,
+                    "name": instance.user.department.company.name
+                }
+                ret['department'] = {
+                    "id": instance.user.department.id,
+                    "code": instance.user.department.code,
+                    "name": instance.user.department.name
+                }
+                ret['user'] = user_object
+                ret['editable_user'] = False
                 ret['editable_comp'] = False
-            else:
-                ret['editable_comp'] = True
-
-            if instance.department  or instance.delegation.lower() == 'requestor':
                 ret['editable_dept'] = False
             else:
-                ret['editable_dept'] = True
-
-            return ret
-        except Exception as e:
-            
-            if instance.user or instance.delegation.lower() == 'requestor':
-                ret['editable_user'] = False
-            else:
-                ret['user'] = None
                 ret['editable_user'] = True
+                ret['editable_comp'] = True
+                ret['editable_dept'] = True
 
-            if instance.company or instance.delegation.lower() == 'requestor':
-                # ret['company'] = model_to_dict(
-                #     instance.company)
+            if instance.company:
+                
                 ret['company'] = {
                     "id": instance.company.id,
                     "code": instance.company.code,
@@ -63,12 +48,10 @@ class ChangeRequestTemplateApproversSerializer(
                 }
                 ret['editable_comp'] = False
             else:
-                ret['company'] = None
                 ret['editable_comp'] = True
 
-            if instance.department  or instance.delegation.lower() == 'requestor':
-                # ret['department'] = model_to_dict(
-                #     instance.department)
+            if instance.department:
+
                 ret['department'] = {
                     "id": instance.department.id,
                     "code": instance.department.code,
@@ -76,9 +59,21 @@ class ChangeRequestTemplateApproversSerializer(
                 }
                 ret['editable_dept'] = False
             else:
-                ret['department'] = None
                 ret['editable_dept'] = True
+            
+            if instance.delegation.lower() == 'requestor':
 
+                ret['editable_user'] = False
+                ret['editable_comp'] = False
+                ret['editable_dept'] = False
+
+            return ret
+        except Exception as e:
+
+            ret['editable_user'] = True
+            ret['editable_comp'] = True
+            ret['editable_dept'] = True
+            
             return ret
 
     class Meta: