Commit 50fdf03c authored by Gladys Forte's avatar Gladys Forte

Merge pull request #499 in RMS/api-main-service from gladys-dev2 to RMSv2

* commit '3d40aff4':
  approver serializer
parents dc8f4a7b 3d40aff4
...@@ -52,10 +52,10 @@ class ChangeRequestFormApproversSerializer( ...@@ -52,10 +52,10 @@ class ChangeRequestFormApproversSerializer(
else: else:
ret['editable_dept'] = True ret['editable_dept'] = True
# not instance.tmp_approver.delegation.code or # not instance.tmp_approver.delegation.code or
# if instance.tmp_approver.delegation.name.lower() == 'requestor': if instance.tmp_approver.delegation or instance.tmp_approver.delegation.name.lower() == 'requestor':
# ret['editable_deleg'] = False ret['editable_deleg'] = False
# else: else:
# ret['editable_deleg'] = True ret['editable_deleg'] = True
else: else:
ret['editable_user'] = True ret['editable_user'] = True
...@@ -104,17 +104,17 @@ class ChangeRequestFormApproversSerializer( ...@@ -104,17 +104,17 @@ class ChangeRequestFormApproversSerializer(
ret['department'] = None ret['department'] = None
ret['editable_dept'] = True ret['editable_dept'] = True
# if instance.tmp_approver.delegation or instance.tmp_approver.delegation.name.lower() == 'requestor': if instance.tmp_approver.delegation or instance.tmp_approver.delegation.name.lower() == 'requestor':
# ret['delegation'] = { ret['delegation'] = {
# "id": instance.tmp_approver.delegation.id, "id": instance.tmp_approver.delegation.id,
# "code": instance.tmp_approver.delegation.code, "code": instance.tmp_approver.delegation.code,
# "name": instance.tmp_approver.delegation.name "name": instance.tmp_approver.delegation.name
# } }
# ret['editable_deleg'] = False ret['editable_deleg'] = False
# else: else:
# ret['delegation'] = None ret['delegation'] = None
# ret['editable_deleg'] = True ret['editable_deleg'] = True
else: else:
ret['editable_user'] = True ret['editable_user'] = True
......
...@@ -692,7 +692,7 @@ def cancelled_user_trigger(form_code): ...@@ -692,7 +692,7 @@ def cancelled_user_trigger(form_code):
Q(entity='CR_FRM_APPROVER') & Q(entity='CR_FRM_APPROVER') &
Q(main_action='ACTION') Q(main_action='ACTION')
).values_list('modifiedby', flat=True).distinct() ).values_list('modifiedby', flat=True).distinct()
received_approvers = models.User.objects.filter( received_approvers = models.User.objects.filter(
username__in=received_approvers) username__in=received_approvers)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment